react-native icon indicating copy to clipboard operation
react-native copied to clipboard

feat: Move Animated to @react-native/animated

Open gabrieldonadel opened this issue 3 years ago • 6 comments

Summary

This PR moves the Animated module to a separate package called @react-native/animated located under packages/animated as proposed on https://github.com/facebook/react-native/issues/35263

Changelog

[General] [Changed] - Move Animated to @react-native/animated package

Test Plan

  1. Open the RNTester app and navigate to Animated page
  2. Test animated functionalities through the many sections

https://user-images.githubusercontent.com/11707729/203903229-9511d0be-8485-433b-be52-57432b5d866b.mov

gabrieldonadel avatar Nov 24 '22 23:11 gabrieldonadel

Warnings
:warning: :lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by :no_entry_sign: dangerJS against 20ea260510c8dbc44b676545b0bd80b2259a9974

github-actions[bot] avatar Nov 25 '22 03:11 github-actions[bot]

Looks like we need to update this because of the monorepo moves

necolas avatar Mar 28 '23 17:03 necolas

Looks like we need to update this because of the monorepo moves

To be honest there are so many conflicts with the new monorepo structure that I'll probably just start this from scratch and force push a new commit

gabrieldonadel avatar Mar 30 '23 01:03 gabrieldonadel

An issue that I recently encountered with the RN Animated is that React.useLayoutEffect in useAnimatedProps causes errors during SSR on Web. IIRC there is a proposal for React.useLayoutEffect to change to a noop during SSR, but if that doesn't land soon, then we'd need to use a user-space useLayoutEffect that avoids the issue.

https://github.com/necolas/react-native-web/commit/338cce194de0ca4a458b82304366b3e6dac94e43

necolas avatar Apr 11 '23 23:04 necolas

Am i able to just fetch from this PR to set my branch from this?

DylanTet avatar Oct 31 '23 18:10 DylanTet

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 29 '24 05:04 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar May 07 '24 05:05 github-actions[bot]