fix(RCTUITextField): apply workaround for UIKit bug that works for multiline to singleline
Summary
See https://github.com/facebook/react-native/commit/e020576b34fb6ca6d3f9fe38916844b78a45c0e3 for rational.
This bug in UIKit does apply for all UITextInput views. So this PR copies over the fix from multiline-view to singleline-view.
Changelog
[iOS] [Fixed] - Make selectTextOnFocus for iOS single line text input fields work every time
Test Plan
Visual inspection. Same bug fix for multiline does work for singleline.
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 7,822,937 | +0 |
| android | hermes | armeabi-v7a | 7,214,837 | +0 |
| android | hermes | x86 | 8,136,540 | +0 |
| android | hermes | x86_64 | 8,114,514 | +0 |
| android | jsc | arm64-v8a | 9,700,925 | +0 |
| android | jsc | armeabi-v7a | 8,456,031 | +0 |
| android | jsc | x86 | 9,652,530 | +0 |
| android | jsc | x86_64 | 10,250,417 | +0 |
Base commit: 8993ffc82e8d4010d82dcb1d69c33a609bb2771a Branch: main
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| ios | - | universal | n/a | -- |
Base commit: 8993ffc82e8d4010d82dcb1d69c33a609bb2771a Branch: main
I've rebased to current main. First PR had flaky iOS test, which now passes. Hope this could be merged at some point...
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR was closed because it has been stalled for 7 days with no activity.