Why is Cython included?

Open lucidfrontier45 opened this issue 3 years ago • 0 comments

I found Cython is still included in the install dependencies. https://github.com/facebook/prophet/blob/95b1741d447c7283363475a63f1ceceaec2981c9/python/requirements.txt#L1

My understanding is that it is required for pystan2. As of Prophet 1.1 the backend is completely moved to cmdstanpy. Why is Cython still required?

Jul 22 '22 00:07 lucidfrontier45

I believe this was an oversight in #2148 and it should be removed

Aug 26 '22 15:08 WardBrian

@tcuongd want to knock this one off as well? I think it’s causing some annoyances for the conda package.

Also worth considering updating the “fbprophet” shim to not pin 1.0 any more

Sep 04 '22 22:09 WardBrian