openr icon indicating copy to clipboard operation
openr copied to clipboard

Fix dependency issues post mvfst/fbthrift introduction

Open earies opened this issue 2 years ago • 4 comments

Title: Update submodules/fix dependency break for fbcode_builder/cmake after mvfst introduction

Description:

  • Post mvfst introduction as a mandatory dependency to fbthrift, build breaks by way of build_openr.sh fbcode_builder/cmake. This also involved upreving the pinned hashes for dependencies since there are multiple variables at play.
  • Brought submodule dependencies up to date and enforced mvfst as dependency to fbthrift. Updated Github workflow to account for mvfst

Test Plan:

  • Successful build by way of build/build_openr.sh

earies avatar Aug 31 '23 23:08 earies

Looks like the CI/CD pipeline here is quite heavy resulting in:

/usr/bin/ranlib: libopenrlib.a: No space left on device

earies avatar Sep 01 '23 17:09 earies

Looks like the CI/CD pipeline here is quite heavy resulting in:

/usr/bin/ranlib: libopenrlib.a: No space left on device

Hey mate - Yeah, this is known. There was plan to get our own large disk worker built and use that, but never been high priority.

Let me see if I can click import to internal and see how interal CI goes.

  • I'm not directly involved anymore, but can't imagine the internal CI could be passing here ...

cooperlees avatar Sep 01 '23 18:09 cooperlees

@cooperlees has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 01 '23 18:09 facebook-github-bot

@cooperlees has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 05 '23 17:09 facebook-github-bot