openbmc icon indicating copy to clipboard operation
openbmc copied to clipboard
verified publisher icon facebook

flashy: Refactor logger interface and restart syslog appropriately

Open lhl2617 opened this issue 5 years ago • 4 comments

Summary: As title. Make logger interface easier to work with, and restart (and reacquire syslog) immediately after killing data partition processes.

Test Plan: Unit tests go test ./...

Flash tests TBD.

lhl2617 avatar Oct 22 '20 13:10 lhl2617

Hi @lhl2617 just saw this one.

doranand avatar Nov 09 '20 16:11 doranand

Hey @doranand no worries - also realised that this might be dangerous because there is a very short interval between "killing" syslog and starting it up, and for every retry it starts it... not sure if this would be good for flaky systems. Nevertheless this makes syslog only dead during the crucial fuser cmd.

lhl2617 avatar Nov 09 '20 16:11 lhl2617

@doranand @kawmarco are we seeing any syslog errors which could benefit from this? this would make logging more reliable :D

lhl2617 avatar Nov 23 '20 14:11 lhl2617

@lhl2617 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 20 '21 17:07 facebook-github-bot

I think this was contributed via phabricator already?

williamspatrick avatar Jul 12 '24 01:07 williamspatrick