litho icon indicating copy to clipboard operation
litho copied to clipboard
verified publisher icon facebook

Revert back to LEGACY mode for Robolectric to test CI

Open colriot opened this issue 4 years ago • 6 comments

Differential Revision: D26400588

colriot avatar Feb 11 '21 13:02 colriot

This pull request was exported from Phabricator. Differential Revision: D26400588

facebook-github-bot avatar Feb 11 '21 13:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D26400588

facebook-github-bot avatar Feb 11 '21 13:02 facebook-github-bot

Hi @colriot , would it make sense instead of executing all litho tests with LEGACY, to only annotate the tests that need LEGACY and let all other tests run with PAUSED? I believe Robolectric LooperMode.LEGACY is now considered deprecated. I have sent a couple of PRs to annotate with LEGACY the tests that need it. Please let me know your thougths.

chggr avatar Feb 11 '21 15:02 chggr

This pull request was exported from Phabricator. Differential Revision: D26400588

facebook-github-bot avatar Feb 11 '21 15:02 facebook-github-bot

Hi @chggr! I'm just trying to debug a tests issue on CI. As you've probably noticed we now have red CI in OSS (though it's green internally). And I'm trying to fix it.

I've also added quite a bunch of Legacy annotations to our tests some time around your PRs :) So, I wanted to ask you to rebase your 2 PRs on top of master, to actualize and merge them

colriot avatar Feb 11 '21 15:02 colriot

Thanks @colriot for fixing the CI build, that's awesome! As discussed I have merged master into the other two PRs that are adding LooperMode.LEGACY where needed and removing it from tests that is not really required. I hope these will help getting to the bottom of these test failures.

https://github.com/facebook/litho/pull/761 https://github.com/facebook/litho/pull/762

chggr avatar Feb 12 '21 13:02 chggr