litho icon indicating copy to clipboard operation
litho copied to clipboard
verified publisher icon facebook

Allow for custom ScrollStateDetector implementation

Open chggr opened this issue 5 years ago • 3 comments

Summary

Support for a default ScrollStateDetector n HorizontalScrollSpec and VerticalScrollSpec was added in a previous PR. This PR allows users to provide their own custom ScrollStateDetector implementation. It breaks the existing ScrollStateDetector class into two: It extracts an interface that users can potentially implement with their own functionality and also creates an additional DefaultScrollStateDetector that now contains the default implementation to be used when no custom implementation has been specified.

Changelog

Allow for custom ScrollStateDetector implementations in HorizontalScrollSpec and VerticalScrollSpec.

Test Plan

This change has been tested via unit tests

chggr avatar Jan 21 '21 18:01 chggr

Thanks @colriot for the review, great feedback! I have made all required changes, please let me know if there is anything else outstanding. Many thanks again and have a great day :-)

chggr avatar Feb 11 '21 15:02 chggr

Hi @arpitratan, @colriot, I hope you are well!

Please let me know if you have any feedback on this PR.

chggr avatar Mar 31 '21 12:03 chggr

@colriot has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 11 '21 20:04 facebook-github-bot