folly
folly copied to clipboard
CPortability.h contains incorrect logic
Some preprocessor checks in folly/folly/CPortability.h are bogus. Using https://github.com/facebook/folly/blob/2aa5ba681d49a7e4f0cacdf2f95432f15fc9a12f/folly/CPortability.h#L74-L102 as a reference:
If a user compiles this with -DFOLLY_SANITIZE_ADDRESS=0 the block on lines 84-98 will be parsed.
Most likely the intent was to #if FOLLY_SANITIZE_ADDRESS on line 83 instead.
This happens on multiples lines on this file: 83, 112, 129, 146, 164