fboss
fboss copied to clipboard
facebook
Darwin: Sync PM and sensor_service
Description
The open PM config PR (#267) are outdated and behind the latest changes that are integrated by Darwin48V. This PR syncs both PM and the sensor_service configs so that they are up to date.
PM updates since #267
- Updates the PM configs to initialize the qsfp ports (1-32) and generate the necessary symlinks.
- Fix misconfigured infoRomConfigs to use the correct register offset of 0x100.
- Update to the latest bspKmodsRpmVersion
- Remove bspKmodsToReload, sharedKmodsToReload, and upstreamKmodsToLoad as they are outdated configs and the loading flow is handled by the kmods.json file on the bsp and the requiredKmodsToLoad attribute.
Sensor_service changes
- Sync Darwin sensor_service config to include all sensors.
- Match pmUnitNames generated used by PM
Testing
Ports on Darwin reflect the expected values through the scd-xcvr driver
# ls /run/devmap/xcvrs/
xcvr_1 xcvr_17 xcvr_24 xcvr_31 xcvr_ctrl_1 xcvr_ctrl_17 xcvr_ctrl_24 xcvr_ctrl_31 xcvr_io_1 xcvr_io_17 xcvr_io_24 xcvr_io_31
xcvr_10 xcvr_18 xcvr_25 xcvr_32 xcvr_ctrl_10 xcvr_ctrl_18 xcvr_ctrl_25 xcvr_ctrl_32 xcvr_io_10 xcvr_io_18 xcvr_io_25 xcvr_io_32
xcvr_11 xcvr_19 xcvr_26 xcvr_4 xcvr_ctrl_11 xcvr_ctrl_19 xcvr_ctrl_26 xcvr_ctrl_4 xcvr_io_11 xcvr_io_19 xcvr_io_26 xcvr_io_4
xcvr_12 xcvr_2 xcvr_27 xcvr_5 xcvr_ctrl_12 xcvr_ctrl_2 xcvr_ctrl_27 xcvr_ctrl_5 xcvr_io_12 xcvr_io_2 xcvr_io_27 xcvr_io_5
xcvr_13 xcvr_20 xcvr_28 xcvr_6 xcvr_ctrl_13 xcvr_ctrl_20 xcvr_ctrl_28 xcvr_ctrl_6 xcvr_io_13 xcvr_io_20 xcvr_io_28 xcvr_io_6
xcvr_14 xcvr_21 xcvr_29 xcvr_7 xcvr_ctrl_14 xcvr_ctrl_21 xcvr_ctrl_29 xcvr_ctrl_7 xcvr_io_14 xcvr_io_21 xcvr_io_29 xcvr_io_7
xcvr_15 xcvr_22 xcvr_3 xcvr_8 xcvr_ctrl_15 xcvr_ctrl_22 xcvr_ctrl_3 xcvr_ctrl_8 xcvr_io_15 xcvr_io_22 xcvr_io_3 xcvr_io_8
xcvr_16 xcvr_23 xcvr_30 xcvr_9 xcvr_ctrl_16 xcvr_ctrl_23 xcvr_ctrl_30 xcvr_ctrl_9 xcvr_io_16 xcvr_io_23 xcvr_io_30 xcvr_io_9
Port 1 is expected to be present
# cat /run/devmap/xcvrs/xcvr_ctrl_1/xcvr1_present
0 <-- 0 is present
Testing with a non-existing xcvr
# cat /run/devmap/xcvrs/xcvr_ctrl_5/xcvr5_present
1 <---- 1 is absent
General Tests
The following sw_tests passed:
- async_logger_test
- fan_service_sw_test
- fsdb_client_test
- platform_config_lib_config_lib_test
- platform_data_corral_sw_test
- platform_helpers_platform_name_lib_test
- platform_manager_config_validator_test
- platform_manager_data_store_test
- platform_manager_device_path_resolver_test
- platform_manager_i2c_explorer_test
- platform_manager_platform_explorer_test
- platform_manager_presence_checker_test
- platform_manager_utils_test
- rackmon_test
- sensor_service_sw_test
- sensor_service_utils_test
- thrift_cow_visitor_tests
- thrift_node_tests
- weutil_crc16_ccitt_test
- weutil_fboss_eeprom_parser_test
The following hw_tests passed:
- data_corral_service_hw_test
- sensor_service_hw_test
- fan_service_hw_test
- weutil_hw_test
@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
