facebook
add mouse event for ReactWheelHandler handleScrollX / handleScrollY
The event.preventDefault() in onWheel breaks the browser zoom in / out while holding the ctrl key and scrolling using the mouse wheel. A fix for this can be done if we return false from handleScrollX / handleScrollY. In order to return false we need to see that ctrl is pressed and for this we need the event.
In my opinion, I find that passing the event is useful and also this is a non breaking change since it is passed as the last argument in the list.
Please see https://github.com/schrodinger/fixed-data-table-2/issues/113 for the actual use case.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!
If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!