facebook
Fixed Flaky test found in `UserDataTest`
Specifically, the tests comes from this line
assertEquals(userData.getExternalIds(), externalIds.subList(0, 2));
in test test/java/com/facebook/ads/sdk/serverside/UserDataTest.java, which is a flaky test that
either pass or fail occasionally on its own. The reason is that externalIds is declared earlier as
List<String> externalIds = Arrays.asList("external-1", "external-2", "external-2");
which ensures externalIds.subList(0, 2)) to always yield {"external-1", "external-2"} and in this
order. However, both userData.externalIds or userData.setExternalIds which set
the external ids field of user data utilize the dedup function defined in src/main/java/com/facebook/ads/sdk/serverside/UserData.java. Because dedup utilizes a hash set
data structure, external id values are not necessarily having a fixed order each time the
function is called, so both userData.externalIds or userData.setExternalIds can either
return {"external-1", "external-2"} or "{external-2", "external-1}" during different runs.
private List<String> dedup(List<String> values) {
if (isListNullOrEmpty(values)) return null;
Set<String> set = new HashSet();
for (String str : values) {
if (str != null) {
set.add(str);
}
}
return new ArrayList(set);
}
In the unit test, I stored the result of userData.getExternalIds in a list and sort the result
before hand, and the assertion should also yield true with the fix.
Hi @sliu-UIUC!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!