errpy icon indicating copy to clipboard operation
errpy copied to clipboard

Dynamic library for native dependency

Open vthemelis opened this issue 2 years ago • 3 comments

Fixes https://github.com/facebook/errpy/issues/4

I'm not sure if this is correct for a multi-target CICD though.

At the moment it just looks into the Rust build output and copies the .so or the .dylib file depending on what is present.

vthemelis avatar Jul 24 '23 20:07 vthemelis

@jasontatton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 03 '23 01:08 facebook-github-bot

@jasontatton, for some more context, this was needed to be able to run pyre in ocamldebug. I added some instruction on how to do that here: https://github.com/facebook/pyre-check/issues/762

I have to say that the debugger doesn't work as well as you'd have hoped (ie it can just crash some times; probably because of the multi-processing) but I thought it was pretty valuable as it is.

vthemelis avatar Aug 11 '23 15:08 vthemelis

Thanks for raising this. I shall make a change which will have the same effect as this PR soon (so effectively merging it). I have to do it this way as our cargo.toml files are derived automatically based on some internal config which is not surfaced within this OSS repo

jasontatton avatar Aug 11 '23 15:08 jasontatton