create-react-app icon indicating copy to clipboard operation
create-react-app copied to clipboard

Check Node version early

Open gaearon opened this issue 7 years ago • 19 comments

We need to add better Node version checks. The current one doesn’t cover all requirements (like Node >= 8.9.0).

gaearon avatar Oct 14 '18 17:10 gaearon

@gaearon, are the checks supposed to be changed under engines in package.json files?

Do I understand it correctly? If yes, I'd be happy to contribute.

vldmrkl avatar Oct 15 '18 04:10 vldmrkl

Hey guys, is someone working on it? I'll be happy to contribute

zivkaziv avatar Nov 17 '18 20:11 zivkaziv

@zivkaziv there's #5482 and #5501 already it looks like. Thanks though!

ianschmitz avatar Nov 17 '18 20:11 ianschmitz

Hey guys, this one is available? Regards!

maximilianotulian avatar Oct 02 '19 23:10 maximilianotulian

Hey @maximilianotulian yes this is available. You should be able to base your work on #5430. Sorry we lost track of this

ianschmitz avatar Oct 03 '19 00:10 ianschmitz

Thanks @ianschmitz, I will give it a try

maximilianotulian avatar Oct 03 '19 02:10 maximilianotulian

Hey @maximilianotulian yes this is available. You should be able to base your work on ~~#5430~~. Sorry we lost track of this

Sorry i meant #5501 @maximilianotulian

ianschmitz avatar Oct 03 '19 04:10 ianschmitz

@gaearon IMO, the pre-install script can check node version and exit if it doesn't find suitable node version.

nsisodiya avatar Apr 24 '20 07:04 nsisodiya

Hey, do I understand correctly the issue? Looks like you are not satisfied with the current version checker (NOT the node version itself)? I took a look into the PRs that was done here and all of them updating the node version. Only this one https://github.com/facebook/create-react-app/pull/5501/files improved version checker, but it was not approved. Could anybody tell me what was wrong with it (apart of yarn.lock in .gitignore)?

dmitrij-borchuk avatar Jun 03 '20 18:06 dmitrij-borchuk

@ianschmitz Can I try this one? Would love to contribute here!

Seems like there is now a check for v10 for node here. Would you like to have specific warnings for other node versions like 8.9.0 etc. If I understand the issue correctly?

I think https://github.com/facebook/create-react-app/issues/9614 can also be looked at under a PR made for this issue.

elit-altum avatar Sep 23 '20 14:09 elit-altum

Hi there, Seems like this is still not done. Is it open for grabs? cheers,

OBACodes avatar Oct 11 '21 10:10 OBACodes

Hey @iansu @raix. Is this issue still up for a grab, I want to take this one up.

tchassijordan avatar Mar 18 '22 12:03 tchassijordan

Hey guys, is someone working on it? I'll be happy to contribute

namann11 avatar Jan 19 '23 14:01 namann11

Hey guys, is someone working on it? I'll be happy to contribute

shrey-suri avatar Jul 19 '23 04:07 shrey-suri

I would like to work on this

Amit-Morade avatar Oct 17 '23 11:10 Amit-Morade

Hi , is someone working on it? I'll be happy to contribute

HarshMankar avatar Feb 07 '24 16:02 HarshMankar

Hi , can you assign me this issue ?

ryuga001 avatar Jan 22 '25 04:01 ryuga001

Hi, I’d like to contribute to this issue. Is anyone actively working on it? If not, I’d love to take it up. 😄

Aarshpatel12 avatar Jun 21 '25 07:06 Aarshpatel12

I'd love to contribute to this. Please check my PR :) https://github.com/facebook/create-react-app/pull/17148

DipakHalkude avatar Sep 23 '25 11:09 DipakHalkude