buck2 icon indicating copy to clipboard operation
buck2 copied to clipboard

Add remote execution example for NativeLink

Open boldpulse opened this issue 1 year ago • 1 comments

boldpulse avatar May 17 '24 15:05 boldpulse

Hi @aleksdmladenovic!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar May 17 '24 15:05 facebook-github-bot

@JakobDegen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 19 '24 06:05 facebook-github-bot

Very cool, thank you!

JakobDegen avatar May 19 '24 06:05 JakobDegen

Could you review this stuff and merge? Thanks. @JakobDegen .

boldpulse avatar May 20 '24 11:05 boldpulse

Super cool. Wow.

MarcusSorealheis avatar May 20 '24 17:05 MarcusSorealheis

@aleksdmladenovic I've imported it into Meta's internal review tool, it's waiting for approval from a second engineer there. I'll be able to merge it once that happens (although note that this PR will be marked as closed, not merged)

JakobDegen avatar May 20 '24 17:05 JakobDegen

Thanks. @JakobDegen . I will be waiting for feedback.

boldpulse avatar May 20 '24 18:05 boldpulse