OpenBIC icon indicating copy to clipboard operation
OpenBIC copied to clipboard

Modify code for sensor reading

Open Yi-Shum opened this issue 3 years ago • 1 comments

Hi @DelphineChiu,

We want to modify the code for sensor reading, including:

  1. The member init_args in struct sensor_cfg should only be used in the function DeviceName_init(). So we want to add a private data member that will be used in other functions such as DeviceName_read().
  2. Add the header files for each sensor.
  3. Changed ADC amplification calculation from arg0 and arg1 to post_sensor_read_hook and post_sensor_read_args.

Do you have any suggestions for this?

Thanks, Yi-Shum

Yi-Shum avatar Mar 22 '22 01:03 Yi-Shum

Hi @Yi-Shum

Meta and we plan to have main_v2 ready on 3/31. Would you pls check main_v2 on https://github.com/facebook/OpenBIC/pull/189/ and provide the optimization based on main_v2?

cc @GoldenBug

Thanks, Delphine

DelphineChiu avatar Mar 22 '22 05:03 DelphineChiu