Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Remove encode/decode test, part II

Open ldworkin opened this issue 4 years ago • 4 comments

Differential Revision: D27712810

ldworkin avatar Apr 12 '21 17:04 ldworkin

This pull request was exported from Phabricator. Differential Revision: D27712810

facebook-github-bot avatar Apr 12 '21 17:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D27712810

facebook-github-bot avatar Apr 12 '21 18:04 facebook-github-bot

Codecov Report

Merging #554 (2578636) into master (1ec92fa) will decrease coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   93.85%   93.84%   -0.01%     
==========================================
  Files         335      335              
  Lines       25268    25234      -34     
==========================================
- Hits        23716    23682      -34     
  Misses       1552     1552              
Impacted Files Coverage Δ
ax/storage/json_store/tests/test_json_store.py 97.79% <ø> (-0.34%) :arrow_down:
ax/storage/sqa_store/tests/utils.py 100.00% <ø> (ø)
ax/storage/utils.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ec92fa...2578636. Read the comment docs.

codecov-io avatar Apr 12 '21 18:04 codecov-io

Hi @ldworkin!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Feb 16 '22 10:02 facebook-github-bot

already committed

saitcakmak avatar Aug 25 '22 21:08 saitcakmak