Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Refactor data-loading for LCBench surrogate benchmark problem

Open ltiao opened this issue 9 months ago • 10 comments

This diff improves the LCBench data-loading and benchmark problem setup. Key changes include:

  • Introducing an alternative constructor option for LearningCurveBenchmarkTestFunction in get_lcbench_early_stopping_benchmark_problem
  • Making data retrieval in LearningCurveBenchmarkTestFunction more flexible with the override-able method _load_lcbench_data
  • Simplifying the benchmark problem by removing unused options (observe_noise_sd, noise_std, seed)
  • Updating naming conventions for LCBench benchmark problems
  • Various minor improvements, including type annotations and refactoring of repetitive code

Differential Revision: D72862531

ltiao avatar Apr 11 '25 15:04 ltiao

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Apr 11 '25 15:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Apr 11 '25 17:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Apr 11 '25 18:04 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.03%. Comparing base (da222b1) to head (19790da).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3634   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files         564      564           
  Lines       56305    56300    -5     
=======================================
- Hits        54074    54070    -4     
+ Misses       2231     2230    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Apr 11 '25 18:04 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Apr 29 '25 19:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar May 07 '25 14:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar May 07 '25 14:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar May 16 '25 20:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar May 19 '25 23:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar May 26 '25 21:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Jul 16 '25 18:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Jul 17 '25 17:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Jul 17 '25 18:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Jul 17 '25 18:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Jul 17 '25 18:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Jul 17 '25 18:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D72862531

facebook-github-bot avatar Jul 17 '25 18:07 facebook-github-bot

This pull request has been merged in facebook/Ax@1822b916f4f661f9be411bf6d3e2ce4a6eb0bbb8.

facebook-github-bot avatar Jul 17 '25 20:07 facebook-github-bot