change flag from supress_generation_errors to raise_generation_errors

[mgarrard]

Summary: Cleans up an easy todo that adds additional clarity to one of the generation node methods where we make raising an error the exception as opposed to the expectation

Differential Revision: D57477070

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D57477070

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D57477070

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.26%. Comparing base (d97a80e) to head (cde454d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2468   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         485      485           
  Lines       47393    47393           
=======================================
  Hits        45147    45147           
  Misses       2246     2246           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[facebook-github-bot]

This pull request has been merged in facebook/Ax@6558d2789f96a387eb25027ea72d36d94ed9ad87.