Support multiple node generation for single trial
Summary: This diff enables multiple nodes to be used to generate a single batch trial. Right now the limitations are that: (1) currently each node only contributes 1 gr to the trial -- we will extend this to n grs in a future diff (2) we don't support multiple transition criterion creating individual forks to another trial -- all trial blocking tc must be met in order to move to the next step --> we don't have a usecase for this right now, so i think it's okay to wait on this. The current implementation should be quite easy to extend to support this.
To do this we added: (1) trial transitions property (2) generation node dict property (3) should_move_trials method and (4) a temp gen method to derisk the dev
Differential Revision: D56743651
This pull request was exported from Phabricator. Differential Revision: D56743651
Codecov Report
Attention: Patch coverage is 99.34211% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 95.32%. Comparing base (
92820ae) to head (0cabf69).
| Files | Patch % | Lines |
|---|---|---|
| ax/modelbridge/generation_node.py | 95.45% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2428 +/- ##
==========================================
- Coverage 95.32% 95.32% -0.01%
==========================================
Files 496 496
Lines 48204 48326 +122
==========================================
+ Hits 45951 46065 +114
- Misses 2253 2261 +8
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request was exported from Phabricator. Differential Revision: D56743651
This pull request was exported from Phabricator. Differential Revision: D56743651
This pull request was exported from Phabricator. Differential Revision: D56743651
This pull request was exported from Phabricator. Differential Revision: D56743651
This pull request was exported from Phabricator. Differential Revision: D56743651
This pull request was exported from Phabricator. Differential Revision: D56743651
This pull request was exported from Phabricator. Differential Revision: D56743651
This pull request was exported from Phabricator. Differential Revision: D56743651
This pull request has been merged in facebook/Ax@231d45dacf2ae61a92b21b8d31811c0cd2499aa9.