facebook
Ban spaces in metric/parameter names in AxClient
Summary: Spaces in names break parsing needed for contraints in AxClient. We discussed many options fo rmoving forward here but this simple solution is the least disruptive
Differential Revision: D56576451
Codecov Report
Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 95.30%. Comparing base (
adcf3a4) to head (cb3ddaa). Report is 47 commits behind head on main.
:exclamation: Current head cb3ddaa differs from pull request most recent head 50be52b. Consider uploading reports for the commit 50be52b to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| ax/service/utils/instantiation.py | 50.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2397 +/- ##
==========================================
+ Coverage 94.91% 95.30% +0.39%
==========================================
Files 491 495 +4
Lines 47788 48401 +613
==========================================
+ Hits 45356 46130 +774
+ Misses 2432 2271 -161
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
