Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Rename ChoiceEncode => ChoiceToNumericChoice

Open mgrange1998 opened this issue 1 year ago • 1 comments

Summary: Renaming the ChoiceEncode parameter to ChoiceToNumericChoice to better reflect its behavior.

Differential Revision: D56311291

mgrange1998 avatar Apr 18 '24 17:04 mgrange1998

This pull request was exported from Phabricator. Differential Revision: D56311291

facebook-github-bot avatar Apr 18 '24 17:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56311291

facebook-github-bot avatar May 07 '24 16:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56311291

facebook-github-bot avatar May 07 '24 16:05 facebook-github-bot

Codecov Report

Attention: Patch coverage is 97.72727% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.31%. Comparing base (2d8fa34) to head (93d850c).

Files Patch % Lines
ax/modelbridge/transforms/choice_encode.py 83.33% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2376   +/-   ##
=======================================
  Coverage   95.30%   95.31%           
=======================================
  Files         494      495    +1     
  Lines       47990    48029   +39     
=======================================
+ Hits        45737    45777   +40     
+ Misses       2253     2252    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 07 '24 16:05 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D56311291

facebook-github-bot avatar May 07 '24 18:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56311291

facebook-github-bot avatar May 07 '24 18:05 facebook-github-bot

This pull request has been merged in facebook/Ax@30c1eea6bc306c222a7cdf2fb3319e784d0e3aa1.

facebook-github-bot avatar May 08 '24 00:05 facebook-github-bot