Speed up `get_pending_observation_features` by ~20ms by not fetching data unnecessarily

[mgrange1998]

Summary: The performance of "get_pending_observations" can be greatly improved by avoiding calls to trial.lookup_data() on trials which are not "in_progress".

Differential Revision: D54417794

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D54417794

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D54417794

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D54417794

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D54417794

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.85%. Comparing base (a1f94b0) to head (b9150a5).

:exclamation: Current head b9150a5 differs from pull request most recent head 576d93e. Consider uploading reports for the commit 576d93e to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2239   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         467      467           
  Lines       46380    46403   +23     
=======================================
+ Hits        43992    44015   +23     
  Misses       2388     2388           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.