Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Fix breaking "fix lint" github signal

Open mgrange1998 opened this issue 1 year ago • 2 comments

Summary: "fix lint" signal is failing on github https://github.com/facebook/Ax/actions/runs/8090412501/job/22107860418#step:6:13

Run flake8
  flake8
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.9.18/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib
./ax/models/torch/tests/test_model.py:8:1: F401 'warnings' imported but unused
Error: Process completed with exit code 1.

Fixing to unbreak

Reviewed By: mpolson64

Differential Revision: D54370344

mgrange1998 avatar Feb 29 '24 18:02 mgrange1998

This pull request was exported from Phabricator. Differential Revision: D54370344

facebook-github-bot avatar Feb 29 '24 18:02 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.85%. Comparing base (fb7e30e) to head (c21dac8).

:exclamation: Current head c21dac8 differs from pull request most recent head a4c1120. Consider uploading reports for the commit a4c1120 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
- Coverage   94.85%   94.85%   -0.01%     
==========================================
  Files         467      467              
  Lines       46381    46380       -1     
==========================================
- Hits        43993    43992       -1     
  Misses       2388     2388              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 29 '24 18:02 codecov-commenter