facebook
Remove completion_criterion file
Summary: We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff we remove the completioncriteria file
In following diffs we will:
- revisit storage
- remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code
- update AEPsych GSs as needed
- determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true
- determine if additional updates to min_asks and run_indefinetly are necessary
Differential Revision: D52854883
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
9bc5329) 94.79% compared to head (ec11291) 94.79%.
:exclamation: Current head ec11291 differs from pull request most recent head a8445ce. Consider uploading reports for the commit a8445ce to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #2138 +/- ##
==========================================
- Coverage 94.79% 94.79% -0.01%
==========================================
Files 462 461 -1
Lines 45670 45660 -10
==========================================
- Hits 43294 43284 -10
Misses 2376 2376
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request has been merged in facebook/Ax@50c6d8cd30596004b97ccad1b0834e39e36e34c2.