facebook
Empty completion criterion file
Summary: We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff we empty the completioncriteria file as recommended prior to deletion
In following diffs we will:
- revisit storage
- remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code
- update AEPsych GSs as needed
- determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true
- determine if additional updates to min_asks and run_indefinetly are necessary
Differential Revision: D52855166
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e11eff7) 94.78% compared to head (5b592ee) 94.78%.
:exclamation: Current head 5b592ee differs from pull request most recent head 8f8d34d. Consider uploading reports for the commit 8f8d34d to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #2137 +/- ##
==========================================
- Coverage 94.78% 94.78% -0.01%
==========================================
Files 460 459 -1
Lines 45433 45422 -11
==========================================
- Hits 43064 43053 -11
Misses 2369 2369
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request has been merged in facebook/Ax@099c69083ae5d720334355ecb391ecbe67d23483.