facebook
Update all instances of MinimumPreferenceOccurances to directly use TransitionCriterion
Summary: We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file
In following diffs we will:
- Completely remove the completion criterion file
- update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15
- revisit storage
- remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code
- update AEPsych GSs as needed
- determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true
Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing
Differential Revision: D52852317
Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
9bc5329) 94.79% compared to head (aeda0df) 94.76%.
:exclamation: Current head aeda0df differs from pull request most recent head 0cac424. Consider uploading reports for the commit 0cac424 to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| ax/modelbridge/completion_criterion.py | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2135 +/- ##
==========================================
- Coverage 94.79% 94.76% -0.03%
==========================================
Files 462 462
Lines 45670 45640 -30
==========================================
- Hits 43294 43252 -42
- Misses 2376 2388 +12
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request has been merged in facebook/Ax@c08f30bb04c74809b1e764e5af5e5148c0108089.