facebook
Add generation_node_name arg to BaseTrial
Summary: As we transition to using GenerationNodes by default in GenerationStrategy, we want to add in a geneartion_node_name argument to Trial Objects. This arg is analogous to the generation_step_index, but more flexibile.
For backwards compatibility purposes, we aren't replacing generation_step_index at this time. I anticipate, over time we will be able to do so.
Things in the pipeline: (1) Update other code impacted by this trial object run chage (2) Add the transition_to field to transition criterion class (3) Update the transition criterion class to check on a per node basis, instead of per experiment (4) add is_complete to generationNode and then use that in generation Strategy for moving forward (5) [Mby] skip max trial criterion addition if numtrials == -1 (6) add transition criterion to the repr string + some of the other fields that havent made it yet
Reviewed By: lena-kashtelyan
Differential Revision: D50279168
Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
cc27fee) 94.62% compared to head (38e162c) 94.62%.
:exclamation: Current head 38e162c differs from pull request most recent head 05da525. Consider uploading reports for the commit 05da525 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #1919 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 459 459
Lines 43637 43657 +20
=======================================
+ Hits 41292 41312 +20
Misses 2345 2345
| Files | Coverage Δ | |
|---|---|---|
| ax/core/batch_trial.py | 96.36% <100.00%> (+0.02%) |
:arrow_up: |
| ax/core/generator_run.py | 100.00% <100.00%> (+0.67%) |
:arrow_up: |
| ax/core/tests/test_generator_run.py | 100.00% <100.00%> (ø) |
|
| ax/core/trial.py | 95.28% <100.00%> (+0.04%) |
:arrow_up: |
| ax/modelbridge/generation_node.py | 98.29% <100.00%> (+0.01%) |
:arrow_up: |
| ax/storage/json_store/encoders.py | 97.74% <ø> (ø) |
|
| ax/storage/sqa_store/decoder.py | 93.63% <100.00%> (+0.01%) |
:arrow_up: |
| ax/storage/sqa_store/encoder.py | 96.69% <ø> (ø) |
|
| ax/storage/sqa_store/sqa_classes.py | 100.00% <100.00%> (ø) |
|
| ax/core/base_trial.py | 95.02% <80.00%> (-0.23%) |
:arrow_down: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
