Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Genericize interactive loop away from AxClient

Open mpolson64 opened this issue 3 years ago • 1 comments

Summary: Move the interactive loop away from requiring AxClient. Use new generic infra to replicate behavior of previous diff in a new method named interactive_optimize_with_client.

Differential Revision: D39545664

mpolson64 avatar Sep 15 '22 16:09 mpolson64

This pull request was exported from Phabricator. Differential Revision: D39545664

facebook-github-bot avatar Sep 15 '22 16:09 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D39545664

facebook-github-bot avatar Sep 27 '22 18:09 facebook-github-bot

Codecov Report

Base: 94.85% // Head: 94.85% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (03e4429) compared to base (1613482). Patch coverage: 96.66% of modified lines in pull request are covered.

:exclamation: Current head 03e4429 differs from pull request most recent head ea6e016. Consider uploading reports for the commit ea6e016 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1143   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         412      414    +2     
  Lines       36954    37021   +67     
=======================================
+ Hits        35053    35117   +64     
- Misses       1901     1904    +3     
Impacted Files Coverage Δ
ax/utils/tutorials/cnn_utils.py 0.00% <0.00%> (ø)
ax/service/interactive_loop.py 100.00% <100.00%> (ø)
ax/service/tests/test_interactive_loop.py 100.00% <100.00%> (ø)
ax/storage/botorch_modular_registry.py 86.95% <0.00%> (-1.73%) :arrow_down:
ax/storage/sqa_store/utils.py 83.33% <0.00%> (-1.67%) :arrow_down:
ax/utils/common/logger.py 70.93% <0.00%> (-0.34%) :arrow_down:
ax/service/tests/test_scheduler.py 98.72% <0.00%> (-0.26%) :arrow_down:
ax/early_stopping/tests/test_strategies.py 99.57% <0.00%> (-0.02%) :arrow_down:
ax/service/utils/instantiation.py 98.20% <0.00%> (-0.01%) :arrow_down:
ax/modelbridge/factory.py 100.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 27 '22 18:09 codecov-commenter