fabrix icon indicating copy to clipboard operation
fabrix copied to clipboard

chore(): Lifecycle listeners should throw a warning if the lifecycle event will not exist

Open scott-wyatt opened this issue 7 years ago • 4 comments

Issue Description

Lifecycle listeners should throw a warning if the lifecycle event will not exist.

Environment

  • node version: 10.0.0
  • fabrix version: > 1.1.4
  • operating system: macOS, Linux

scott-wyatt avatar Aug 07 '18 23:08 scott-wyatt

Maybe this will be the year! #hacktoberfest

scott-wyatt avatar Oct 14 '19 13:10 scott-wyatt

Not sure there is enough details to be taken into an hacktoberfest ^^ even me who know a bit the subject I don't understand the issue :D

Can you explain more what's need to be done here ? maybe with a use case

jaumard avatar Oct 23 '19 11:10 jaumard

Haha, sorry! Basically, if a spool is waiting for some event like “spool:sequelize:initialized”, if you don’t have spool sequelize installed, that event will never be emitted. So eventually, fabrix timeout will occur and the user won’t know why.

Sent from out and about

On Oct 23, 2019, at 6:48 AM, Jaumard [email protected] wrote:

 Not sure there is enough details to be taken into an hacktoberfest ^^ even me who know a bit the subject I don't understand the issue :D

Can you explain more what's need to be done here ? maybe with a use case

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

scott-wyatt avatar Oct 23 '19 12:10 scott-wyatt

now I understand :p ha ha no worry :)

but how can we do that ? just parsing the event to retrieve sequelize and check that the spool is available under main.spools ? but we have to keep in mind that wanted event can be "or" or "and" (if I remember correctly ^^) so we need to manage that logic too

jaumard avatar Oct 23 '19 13:10 jaumard