wide-github icon indicating copy to clipboard operation
wide-github copied to clipboard

Doesn't work for corporate Githubs with non-com TLD

Open KaiRoesner opened this issue 5 years ago • 9 comments

It would be nice to have this extension work for corporate Githubs that have a TLD other than ".com". Instead of matching patterns it might be a good idea to have an explicit and user configurable white list of domains for which the extension should be enabled. The "Github Dark Theme" extension handles the problem in this way, for example.

KaiRoesner avatar Nov 24 '20 09:11 KaiRoesner

@KaiRoesner Thanks for reporting. Wide GitHub 2.0.0 adds support for github.*.io domains. If this doesn't cover most of the use-cases, I'll be happy to explore your suggestion for a future release.

fabiocchetti avatar Jan 10 '21 11:01 fabiocchetti

Reopening this issue because of @MahatmaFatalError's comment here (Issue #5). I'll try to implement a wider support for GitHub Enterprise custom domains in a future release.

fabiocchetti avatar Jan 11 '21 00:01 fabiocchetti

Did this get merged in? I just installed this for use on a corporate GitHub, but it does not seem to be working.

KalebMills avatar Jan 25 '21 22:01 KalebMills

@KalebMills , I'm now using this style instead which has a configurable list of domains for which the style is enabled. github.*.io does not work for us, we have several github domains, e.g. with .corp tld.

KaiRoesner avatar Jan 26 '21 07:01 KaiRoesner

Did this get merged in? I just installed this for use on a corporate GitHub, but it does not seem to be working.

@KalebMills , I'm now using this style instead which has a configurable list of domains for which the style is enabled. github.*.io does not work for us, we have several github domains, e.g. with .corp tld.

I can confirm as of now Wide GitHub for Firefox works with github.*.io and github.*.com domains only. I'll add support for custom TLDs in a future release. Thanks for reporting.

fabiocchetti avatar Jan 31 '21 12:01 fabiocchetti

IMO having an option in the extension to enable it for a specific domain, like Refined Github, would be better.

jmcs avatar May 18 '21 06:05 jmcs

Hey @KaiRoesner, this feature is now supported with version 3.0.0.

Please feel free to give it a try and let me know if everything works as expected.

— cc @KalebMills, @jmcs

fabiocchetti avatar May 08 '25 01:05 fabiocchetti

I'm on Chrome...

KaiRoesner avatar May 08 '25 09:05 KaiRoesner

I'm on Chrome...

Now that I migrated the extension to Manifest V3 I'm planning to release it on Chrome soon, stay tuned!

fabiocchetti avatar May 08 '25 09:05 fabiocchetti