angular-fullscreen icon indicating copy to clipboard operation
angular-fullscreen copied to clipboard

Emitting from $rootScope

Open narthur157 opened this issue 9 years ago • 1 comments

Maybe I'm not understanding something, but shouldn't the event be broadcasted rather than emitted? https://github.com/fabiobiondi/angular-fullscreen/blob/master/src/angular-fullscreen.js#L16

narthur157 avatar Jan 05 '17 22:01 narthur157

$emit - Dispatches an event name upwards through the scope hierarchy notifying the registered $rootScope.Scope listeners. https://docs.angularjs.org/api/ng/type/$rootScope.Scope

Seems like nobody will get notified by this

narthur157 avatar Jan 05 '17 22:01 narthur157