java-json-benchmark icon indicating copy to clipboard operation
java-json-benchmark copied to clipboard

jdk 11 and some more improvements

Open ozkanpakdil opened this issue 3 years ago • 2 comments

java 17 has some issues, you can see them in history of https://github.com/ozkanpakdil/java-json-benchmark/blob/899e5f7cedc288926585d271f3c4cfe1e44cb7e7/output/clients-deser-1-1.txt

TOKEN_GIT required for index.md for other "output" folder publish to repo. can be created from https://github.com/settings/tokens, I gave all permissions and now github action can commit back all.

ozkanpakdil avatar Oct 28 '22 19:10 ozkanpakdil

Please do not check-in output/*.txt files. Feel free to add a gitignore rule for that.

fabienrenaud avatar Oct 28 '22 20:10 fabienrenaud

but it is helping to see java 17 errors from output folder ? it can be useful for future.

ozkanpakdil avatar Oct 28 '22 21:10 ozkanpakdil

There should be no output errors in results. If there are, they either need to be fixed or the lib causing them needs to disabled for the target jvm until they are fixed.

All the errors I see clients-deser-1-1.txt are from jsoniter.

  • Did you try upgrading libs to their latest version?
  • Did you file a bug with the maintainer of that lib?

fabienrenaud avatar Oct 30 '22 03:10 fabienrenaud

added the git ignore. no I did not tried to upgrade lib, jsoniter has similar issues in their issue list so I did not open any ticket to them.

ozkanpakdil avatar Oct 30 '22 15:10 ozkanpakdil

jsoniter has similar issues in their issue list

Can you link to the issue here please? IIRC, the maintainer of jsoniter added jsoniter to this project so they may be interested in fixing that issue sooner than later to keep the lib in this benchmarked.

fabienrenaud avatar Oct 30 '22 15:10 fabienrenaud

jsoniter has similar issues in their issue list

Can you link to the issue here please? IIRC, the maintainer of jsoniter added jsoniter to this project so they may be interested in fixing that issue sooner than later to keep the lib in this benchmarked.

I saw java 16 record related one but did not see any for java 17 NPE created a new one https://github.com/json-iterator/java/issues/332

ozkanpakdil avatar Oct 30 '22 18:10 ozkanpakdil