[DEL] Remove `.from_inner2`

Open f-dangel opened this issue 2 years ago • 2 comments

Resolves #37.

Oct 26 '23 21:10 f-dangel

Yes, you are right that there are different pros and cons. I tried to sum them up in the following note:

Actually, having done the analysis I think we need to discuss whether we should aim for simplicity by supporting only from_inner, or should dynamically switch between from_inner versus from_inner2 depending on batch_size, sequence_length, feature_dim. In the scenario you mention above, using the from_inner2 approach might save a lot of memory.

For now, I will not merge and label this for 'needs discussion'.

Oct 27 '23 14:10 f-dangel

@yorkerlin please add this to the agenda for our next in-person discussion

Oct 27 '23 15:10 f-dangel