htmlpurifier icon indicating copy to clipboard operation
htmlpurifier copied to clipboard

Ambiguous class HTML5 resolution

Open bentinata opened this issue 6 years ago • 1 comments

I'm currently trying to incorporate rector into my projects, and it complains about:

Ambiguous class HTML5 resolution; defined in ./vendor/ezyang/htmlpurifier/maintenance/PH5P.php and in ./vendor/ezyang/htmlpurifier/library/HTMLPurifier/Lexer/PH5P.php.  

Here's the offending code: https://github.com/ezyang/htmlpurifier/blob/fe0452d6887a0fa76e2eaf80166e1ea205e7bb81/library/HTMLPurifier/Lexer/PH5P.php#L70 https://github.com/ezyang/htmlpurifier/blob/fe0452d6887a0fa76e2eaf80166e1ea205e7bb81/maintenance/PH5P.php#L2

Would it be technically fine if I rename one of the class? I think the lexer one would be fine since it's a subclass.

Thanks.

bentinata avatar Dec 27 '19 08:12 bentinata

Yeah, feel free to submit a PR renaming, I'll merge it.

ezyang avatar Jan 02 '20 11:01 ezyang