git-ftp icon indicating copy to clipboard operation
git-ftp copied to clipboard

feature request: improved symbolic link support

Open JasonWoof opened this issue 12 years ago • 2 comments

Before I was wise in the ways of ftp, I created several sites with a symbolic link in the root folder which points to a file in a submodule.

When I upload a site with such a configuration, it initially works perfectly. git-ftp uploads the symbink with no special treatment, and it shows up on the server as a copy of the file (ie dereferenced.)

All's well and good so far.

Trouble is, when I update the file in the submodule that the link points to, and git ftp push again, it doesn't re-upload the symbolic link. So then the copy on the server (the one that's a symbolic link on my home computer) is out of date.

My request: make it so git-ftp would upload the symbolic link again, when the file it links to is uploaded. And in particular that this works even if the target is in a submodule.

I hope that's clear.

Thank you for this very handy program!

JasonWoof avatar Aug 23 '13 02:08 JasonWoof

Hmm, the real problem here is git-ftp doesn't know about symbolic links, so it is not uploading a symbolic link, it is uploading a copy of the file. It would be rather difficult to reverse engineer all of the places which might need to get updated, so probably a better solution is to arrange that a symbolic link is actually created on the other end. But to add insult to injury, FTP doesn't actually support creating symlinks natively. So I'm not even sure what I would do here.

ezyang avatar Aug 23 '13 16:08 ezyang

oh dear... I meant to report this bug agaist resmo's git-ftp. Not sure why I went with that one. I'm a little terrified about the number shell escaping bugs.

JasonWoof avatar Aug 23 '13 20:08 JasonWoof