ezsystems
Added information in regards to DFS and static files
| Question | Answer |
|---|---|
| Type | Improvement |
| Target version | 1.0 |
| BC breaks | no |
| Doc needed | yes |
If the project is set to use DFS to serve static files, the Response's Vary header will always be set to Cookie, Authorization due to the missing X-User-Hash header inside Request coming from Varnish.
Hi @vidarl - Please take a second look - I've probably updated the text when you were writing your review. But I agree that this might not be the best solution - probably we should introduce a second file for the dfs setup and take advantage of the fact, that User context should be applied only for:
/var/([^/]+/)?storage/images(-versioned)?/
👍
I didn't see that last commit while doing the review, correct.
And you are right, it is quite different if a file is located in assets/ or var/
But I think I would rater say skip User Context for any file in assets/, and get User Context for anything else.
For instance, a .pdf file would never be located in (....)/storage/images(...), but we still would like to get User Context for it
@vidarl @mateuszbieniek this one looks like a "low hanging fruit" mergabe without QA as it applies to code comment only. What is the status here?
I see that this applies to eZ Platform 2.5, which is now past EOM, so it would require a rebase.
