gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Add new line support for multi-line input box

Open extrawurst opened this issue 4 years ago • 3 comments

this is almost done in #509 by @WizardOhio24 - someone just needs to bring it to the finish line

extrawurst avatar May 16 '21 12:05 extrawurst

What is left to do here?

IndianBoy42 avatar Jul 03 '21 21:07 IndianBoy42

At the moment, the multi-line mostly works, there are a few glitches which need sorting out which can cause the state to become inconsistent, but it mostly works right now (it just doesn't always work). As well as adding multiline editing, this PR allows the commit box to expand rather than adding a scroll bar immediately and only adds a scroll bar if the commit box is big enough - it is the scrollbar and the scrolling which can cause the inconsistent state (if I remember correctly), the editing and expanding box worked (I think).

Feel free to take it on. And if you have any questions on the PR, feel free to ask.

WizardOhio24 avatar Jul 04 '21 08:07 WizardOhio24

I've merged it into my fork to try it, I'll play whack-a-mole with any bugs i see as i use it

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Richard Menzies @.> Sent: Sunday, July 4, 2021 4:48:28 PM To: extrawurst/gitui @.> Cc: Anshuman MEDHI @.>; Comment @.> Subject: Re: [extrawurst/gitui] Add new line support for multi-line input box (#711)

At the moment, the multi-line mostly works, there are a few glitches which need sorting out which can cause the state to become inconsistent, but it mostly works right now (it just doesn't always work). As well as adding multiline editing, this PR allows the commit box to expand rather than adding a scroll bar immediately and only adds a scroll bar if the commit box is big enough - it is the scrollbar and the scrolling which can cause the inconsistent state (if I remember correctly), the editing and expanding box worked (I think).

Feel free to take it on. And if you have any questions on the PR, feel free to ask.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/extrawurst/gitui/issues/711#issuecomment-873548512, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABNUNQJ4MMNVQYKMISY5UELTWAN5ZANCNFSM446ZWIIA.

IndianBoy42 avatar Jul 04 '21 09:07 IndianBoy42

Released in 0.25

extrawurst avatar Mar 03 '24 11:03 extrawurst