gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Follow XDG spec on windows

Open dsisnero opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. I use windows and have set XDG_CONFIG dirs (XDG_CONFIG_HOME, XDG_CACHE_HOME) but gitui isn't honoring them

Describe the solution you'd like If XDG_CONFIG_HOME is set on any os, use XDG_CONFIG_HOME/gitui as directory for config file. If it is not set, fall back to os default

dsisnero avatar Jan 06 '23 17:01 dsisnero

sounds plausible. should be an easy change. are you willing to make a PR?

extrawurst avatar Jan 08 '23 11:01 extrawurst

@dsisnero what XDG_XXX_HOME settings were not working for you. Most of the git plumbing is done by a common git library (libgit2) that does obey XDG on all platforms, including windows.

gitui has a couple of places itself where is does not check where it should or could but thats very limited (location of generated log file, location of keyboard mapping file)

I can fix those but want to be sure I have not missed something

pm100 avatar Apr 14 '23 18:04 pm100

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 15 '23 06:12 stale[bot]