Add word motions to text input
It changes the following:
- Add common word motions to the text input component, more precisely
Ctrl-Left,Ctrl-Right,Ctrl-Backspace/Ctrl-WandCtrl-Delete. A word is being defined as a continuous sequence of alphanumeric characters.
I followed the checklist:
- [x] I added unittests
- [x] I ran
make checkwithout errors - [x] I tested the overall application
- [ ] I added an appropriate item to the changelog
this does not work on macos
I have tested this on Windows and Linux (WSL). Unfortunately I don't have access to a macOS to test this. Can you tell me how exactly this is not working? The only platform dependent code I think might not be working is the ctrl modifier check, but this seems to be equivalent to the others in the codebase.
can you please record how this should look like?
@extrawurst I recorded it inside visual studio code for the keystrokes overlay. I notice that Ctrl-Delete don't work in vscode integrated terminal, but it does work in Windows Terminal.
https://user-images.githubusercontent.com/51273772/188209077-e6a13fdf-4f86-493b-a7eb-7cef66daa2d6.mp4
it breaks on unicode text with multibyte content, try some emojis. it will run into some endless loop.
edit: try this commit message ❤️🤯 adasd asdasd and try jumping words from left to right. please write a unittest for it
@extrawurst the infinite loop is fixed.
also the changelog entry is still missing
could you record a nice gif we can put in the changelog of the new functionality?
I don't have a easy recording workflow setup.
Thanks for implementing this!