gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Add keybind to checkout commit in log view

Open Omnikar opened this issue 4 years ago • 4 comments

This Pull Request fixes/closes #983.

It changes the following:

  • Adds Shift-S keybind to checkout the selected commit in the log view.

I followed the checklist:

  • [ ] I added unittests
  • [x] I ran make check without errors
  • [x] I tested the overall application
  • [x] I added an appropriate item to the changelog

I think it'd be better if I could add a confirmation before detaching HEAD, similar to the one used for branch deletion and such, but I'm not sure how to.

Omnikar avatar Dec 26 '21 16:12 Omnikar

How do I get the keybind to appear in this bar at the bottom? image

Omnikar avatar Dec 27 '21 18:12 Omnikar

How do I get the keybind to appear in this bar at the bottom?

checkout the commands fn next to events to see how components add their commands

extrawurst avatar Dec 27 '21 18:12 extrawurst

@Omnikar feel free to reach out on our discord aswell

extrawurst avatar Jan 09 '22 15:01 extrawurst

@Omnikar are you planning to follow this up?

extrawurst avatar Jan 21 '22 21:01 extrawurst

Hey @extrawurst , I'm willing to pick this issue up. I see you left a couple of comments to the original author regarding unit tests and code reuse, should I pick up their branch and fix this stuff, or would you suggest rewriting the whole thing from scratch?

fralcow avatar Jan 04 '23 20:01 fralcow