extinctsion
New Operations for Number System Conversions
If that is the case how about binary to hex and binary to octal? It looks like those operations don't exist yet.
Hi! I got an email notification with a reply in which you said you want to write some unit tests. For some reason I don't see this part of the conversation in github. But of course you can write some unit tests on it.
@IltisGraph for the time being I haven't merged your PR and stated the issue with ur PR there. Pls solve that part.
Hi @IltisGraph I can take up the task to write unit tests. @extinctsion it looks like unit tests are not written for any of the functions. I think we should write unit tests to validate that the functions work for all cases. I will create a new issue for unit tests on existing functions and assign the issue to myself as a task for myself to help contribute to this repo.
@extinctsion I will work on adding a function that will convert from binary to octal
sure. in meanwhile im trying to fix the issue with init.py and im working on CI/CD with my team.
sure. in meanwhile im trying to fix the issue with init.py and im working on CI/CD with my team.
https://github.com/extinctsion/easyPythonpi/pull/31
@extinctsion I made another commit to pr in https://github.com/extinctsion/easyPythonpi/pull/31. Please feel free to take a look at this. In the meantime, assign me the task of adding a function that converts from binary to octal.
@extinctsion I made some changes to the repo by adding a function that converts from binary to octal using the same forked repo. How should I make a pr to this
if binary to octal was not added to master, You can raise PR here or you can raise PR somewhere else as you like. If it matches the requirement, ill merge it.
@AndrewHUNGNguyen @IltisGraph @mclmza @AKG1301 hi, recently I made a new repo. You can check this repo. If you have something to share and contribute, feel free to raise PRs.
@extinctsion here is the pr to master branch. For some reason github thinks the stuff I added for binary to hexadecimal is not merged to master yet https://github.com/extinctsion/easyPythonpi/pull/32
@extinctsion looks like build for my recent pr to master failed. Do you happen to know why?
@AndrewHUNGNguyen I fixed that issue that was happening bcoz I was using old ubuntu mc for building the pkg. Now it is fixed.
@extinctsion gotcha. Other than refactoring the factorial function, do you see any operations that should be included? If I remember correctly from when we last talked, I think we were talking about removing nodes from linked lists?
I was thinking maybe there should be new binary operations like ones and twos complement.
Let me know what you think.
Hi @nancy-singh10 can you tell what are your ideas that you would like to include in this repo? ill assign the task accordingly
Hi @AndrewHUNGNguyen, after a longggggggg timeeeee..... I think there is always a room for better code. We can optimise our library by implementing better code. We need to structure the library for which I will need help. Also we can add more unit testng code for the newly added methods.
Hi @extinctsion long time no talk! In case you didn't get my email, when would be a good time to discuss with you about changes/improvements to the repository? I totally agree that the repository needs refactoring/restructuring