libR-sys icon indicating copy to clipboard operation
libR-sys copied to clipboard
verified publisher icon extendr

Fix bindings failure on PRs

Open CGMossa opened this issue 2 years ago • 2 comments

This is not an implementation of #204.

Currently, PRs that change libR-sys cannot pass CI checks.

CI workflow right now: Runs checks + layout-tests. Uploads generated bindings (to other workflows). Then runs tests on precomputed bindings (that aren't "in" at the moment). This fails, because the generated bindings are not the precomputed bindings, the precomputed bindings are the ones from main / master.

Example of PRs that can't pass CI, even if the PR passes tests, are #206 and #205.

What this PR does is add a procedure that would commit the generated bindings, resulting from running CI, when the last commit message contains [generate bindings].

CGMossa avatar Nov 17 '23 14:11 CGMossa

I have an issue now that it is running the workflow that pushes the bindings every time anything is run. image

CGMossa avatar Nov 17 '23 16:11 CGMossa

This is fixed now, and I've rebased it to remove all the annoying commits.

CGMossa avatar Nov 19 '23 13:11 CGMossa