libR-sys icon indicating copy to clipboard operation
libR-sys copied to clipboard
verified publisher icon extendr

Make C-enums into idiomatic rust enums

Open CGMossa opened this issue 2 years ago • 3 comments

There are several "inferred" enums in the R-API. This setting ensures that they become idiomatic Rust enums. There are still missing ones, namely the macro-defined-enums, but maybe I'll add those somewhere else.

CGMossa avatar Nov 16 '23 14:11 CGMossa

/bindings

CGMossa avatar Nov 16 '23 16:11 CGMossa

Hm, should we already bump libR-sys version to some 0.7.0-dev value? This is a significant breaking change, I want to see a difference between the released 0.6.0 and what is currently developed.

Ilia-Kosenkov avatar Nov 19 '23 18:11 Ilia-Kosenkov

Sure. Please make a PR that bumps the version.

CGMossa avatar Nov 19 '23 18:11 CGMossa

Checking my comments, I do not get it why can't we mark this as 0.7.0?

Ilia-Kosenkov avatar Apr 20 '24 15:04 Ilia-Kosenkov

Bumped version.

CGMossa avatar Apr 20 '24 15:04 CGMossa

Checking my comments, I do not get it why can't we mark this as 0.7.0?

Hard to remember.. I guess I saw that you'd make separate PRs to bump the version in rextendr. And I asked you to do it here maybe because I thought it was more elaborate than just changing a file.

CGMossa avatar Apr 20 '24 15:04 CGMossa