cart icon indicating copy to clipboard operation
cart copied to clipboard

Shipping calculations service class: wrong method call

Open stoppeye opened this issue 2 years ago • 1 comments

Bug Report

Current Behavior Finishing an order with a service class that implements \Extcode\Cart\Domain\Model\Cart\ServiceInterface leads to an exception: Call to undefined method Vendor\MyExt\Service\ShippingRates::getTaxes()

Expected behavior/output No error, if the ServiceInterface was fully implemented.

Environment

  • TYPO3 version(s): 11.5.30
  • cart version: 8.6.1

Possible Solution Fix method call (if the correct call should be to getTax()) or add getTaxes() to interface.

stoppeye avatar Nov 13 '23 08:11 stoppeye

@extcode It seems like you already added getTaxes() in the interface: https://github.com/extcode/cart/blame/main/Classes/Domain/Model/Cart/ServiceInterface.php#L47

@stoppeye Does it work for you when using the main branch where the fix is already included? Can this ticket be closed?

rintisch avatar Mar 25 '24 12:03 rintisch

As I did not get any feedback I will close this issue now.

rintisch avatar May 31 '24 06:05 rintisch