generator icon indicating copy to clipboard operation
generator copied to clipboard
verified publisher icon expressjs

Convert to ES2015

Open redaktice opened this issue 5 years ago • 3 comments

Update templates to use const and arrow functions. Update test JS files to use ES2015 syntax

Inspired by https://github.com/expressjs/generator/pull/252

redaktice avatar Oct 01 '20 01:10 redaktice

Have been waiting a long time for this change. Any chance that this pull request gets merged?

gfeller avatar Oct 05 '20 07:10 gfeller

Hi @gfeller , can you ellaborate on the goal of this PR? It seems to change the style of both the internal generator code and the templated code. Is this desired?

There is nothing wrong with adding a newer es templated code that is an option to the generator, of course, though it doesn't seem like this PR keeps the old format around still under such an option.

The actual generator code it seems to no longer follow the StandardJS format, which we require our org projects to follow, like this one was doing before. Does StandardJS prevent the change to the new style or something?

dougwilson avatar Oct 07 '20 00:10 dougwilson

Internal generator code must follow StandardJS style.

No problem @dougwilson, I made the change back to the StandardJS format

redaktice avatar Oct 07 '20 00:10 redaktice