expressjs.com icon indicating copy to clipboard operation
expressjs.com copied to clipboard

Sun icon missing everywhere except En Header - Add it

Open chrisdel101 opened this issue 1 year ago • 4 comments

The sun icon was only added to English. Might as well add it to the entire site.

Also moon icon was 2x size originally and was changed. Re-add the 2x since it looks better.

Changes here should only be the addition of the sun icon to every header file.

chrisdel101 avatar Aug 12 '24 00:08 chrisdel101

Deploy Preview for expressjscom-preview ready!

Name Link
Latest commit 05acf283e1a315fdb3f02d06f28a7cee707d4af6
Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66cd2e8bbc02a80008ea0d65
Deploy Preview https://deploy-preview-1570--expressjscom-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 12 '24 00:08 netlify[bot]

All the tests are failing. Looks like ruby version error? I've never had this happen here before.

This PR should only be a single commit but those 5 merges are tacked on for some reason. Maybe it's related to those.... Looks like a ruby versioning error. Not even where to set this?

Edit: I see it's actually #1566

chrisdel101 avatar Aug 12 '24 00:08 chrisdel101

#1566 was merged, but tests are still failing. @chrisdel101 I wonder if a trivial commit to this fork/branch might re-run the tests so they would now pass?

crandmck avatar Aug 25 '24 20:08 crandmck

Seems fixed after a full re-merge with main.

chrisdel101 avatar Aug 27 '24 02:08 chrisdel101

Thanks again @chrisdel101 !

crandmck avatar Sep 02 '24 19:09 crandmck