expo-github-action icon indicating copy to clipboard operation
expo-github-action copied to clipboard

continuous-deploy-fingerprint outputs build ids even if no one was started

Open giorgiofellipe opened this issue 1 year ago • 1 comments

Description of the bug

After running continuous-deploy-fingerprint I have in the outputs the build ids for both platforms, even if they are old ones, no one was started

To Reproduce

Setup continuous-deploy-fingerprint on a project an run the workflow twice

Expected behavior

It is expected (as docs says) to only have the outputs android-build-id and ios-build-id when they have been started in this run

Actual behavior

Always have the outputs android-build-id and ios-build-id

Additional context

giorgiofellipe avatar Jun 27 '24 16:06 giorgiofellipe

Can confirm the same issue

kevinschaffter avatar Jul 04 '24 21:07 kevinschaffter

This is good feedback. I'll update it to also include boolean outputs indicating whether this run started each build. I think including the build ID that matches in the output is still useful regardless of whether this run started one though, since a subsequent step in the workflow could use that info somehow.

wschurman avatar Sep 18 '24 22:09 wschurman