jsonrpcserver icon indicating copy to clipboard operation
jsonrpcserver copied to clipboard

Consider merging request-schema.json into a .py file

Open voice-of-texnoforge opened this issue 4 years ago • 3 comments

Hello,

I've hit a little issue when using jsonrpcserver with PyInstaller:

FileNotFoundError: [Errno 2] No such file or directory: `path-to\\jsonrpcserver\\request-schema.json'

I've submitted a simple hook for PyInstaller which fixes this but I've hit similar issues with python packaging and non-py files many times in the past and I suggest you consider moving the .json data into a .py file unless there's a good reason not to - it can be a new request_schema.py or any of existing files.

This would prevent similar problems with python packaging in various tools without requiring additional effort.

Either way, thanks for the nice library ♥

voice-of-texnoforge avatar Jun 12 '21 17:06 voice-of-texnoforge

Yes, good idea. Can’t see any reason not to do this.

bcb avatar Jun 13 '21 00:06 bcb