DDPM-Pytorch icon indicating copy to clipboard operation
DDPM-Pytorch copied to clipboard

first FC layer is missing for time_emb generation

Open ishan-modi opened this issue 1 year ago • 0 comments

self.t_emb_layers = nn.ModuleList([ nn.Sequential( nn.SiLU(), nn.Linear(t_emb_dim, out_channels) ) for _ in range(num_layers) ])

shouldn't it be following instead

self.t_emb_layers = nn.ModuleList([ nn.Sequential( nn.Linear(t_emb_dim, out_channels), nn.SiLU(), nn.Linear(out_channels, out_channels) ) for _ in range(num_layers) ])

I checked unet_2d.py from huggingface and it also has 2 linear FC layers, let me know if I am missing something.

ishan-modi avatar Feb 20 '25 06:02 ishan-modi