cli icon indicating copy to clipboard operation
cli copied to clipboard

feat(completion): fig completion added

Open rama-kairi opened this issue 3 years ago • 3 comments

rama-kairi avatar Oct 15 '22 07:10 rama-kairi

image

rama-kairi avatar Oct 15 '22 07:10 rama-kairi

I just published it for my personal use now.

you can follow the doc - https://fig.io/docs and may extend it further.

rama-kairi avatar Oct 15 '22 07:10 rama-kairi

Hi @rama-kairi,

Thanks for your suggestion! We don't have fig users internally so can't comment on the code but everything looks good. A couple of comments:

  • The command is top-level which would be a bit confusing, it should be nested under a separate namespace
  • The resulting typescript completion help shouldn't be bundled in the codebase. I'll let the other maintainers weigh-in as well.
  • The PR bumps the cobra/viper dependency, a bit of time will be needed to ensure no regressions occurred since the cobra part isn't tested at the moment

pyr avatar Nov 08 '22 20:11 pyr

I moved fig command to a dedicated namespace (integrations). It's not shown in the help as fig-cobra integration sets hidden attribute on the command (still useful to have a namespace for a 3rd party tools integration).

kobajagi avatar Jan 18 '23 14:01 kobajagi